Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export custom header methods #552

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: export custom header methods #552

merged 2 commits into from
Dec 10, 2024

Conversation

KiwiKilian
Copy link
Collaborator

@KiwiKilian KiwiKilian commented Dec 10, 2024 •
edited
Loading

Fixes #551

The Exports Test was quite loose before, not notifying about changes happening on the exports. That's now quite strict.

@KiwiKilian KiwiKilian changed the title fix: epxort custom header methods fix: export custom header methods Dec 10, 2024
@KiwiKilian KiwiKilian requested a review from tyrauber December 10, 2024 10:44
tyrauber
tyrauber approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@tyrauber tyrauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Looks good to me. If CI pass, merge. Thank you!

@KiwiKilian KiwiKilian merged commit 58abdb0 into maplibre:beta Dec 10, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
@semantic-release-bot
chore(release): 10.0.0-beta.8 [skip ci]
cc4f29d 
# [10.0.0-beta.8](v10.0.0-beta.7...v10.0.0-beta.8) (2024-12-10)

### Bug Fixes

* export custom header methods ([#552](#552)) ([58abdb0](58abdb0)), closes [#551](#551)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 10.0.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KiwiKilian KiwiKilian deleted the fix/custom-header branch December 16, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrauber tyrauber tyrauber approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KiwiKilian @tyrauber